Update buildroot to 2021.02.1 (#1312)
Signed-off-by: Stefan Agner <stefan@agner.ch>
This commit is contained in:
39
buildroot/boot/grub2/0086-loader-xnu-Fix-memory-leak.patch
Normal file
39
buildroot/boot/grub2/0086-loader-xnu-Fix-memory-leak.patch
Normal file
@@ -0,0 +1,39 @@
|
||||
From bcb59ece3263d118510c4440c4da0950f224bb7f Mon Sep 17 00:00:00 2001
|
||||
From: Darren Kenny <darren.kenny@oracle.com>
|
||||
Date: Thu, 26 Nov 2020 12:53:10 +0000
|
||||
Subject: [PATCH] loader/xnu: Fix memory leak
|
||||
|
||||
The code here is finished with the memory stored in name, but it only
|
||||
frees it if there curvalue is valid, while it could actually free it
|
||||
regardless.
|
||||
|
||||
The fix is a simple relocation of the grub_free() to before the test
|
||||
of curvalue.
|
||||
|
||||
Fixes: CID 96646
|
||||
|
||||
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
|
||||
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
||||
Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
|
||||
---
|
||||
grub-core/loader/xnu.c | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/grub-core/loader/xnu.c b/grub-core/loader/xnu.c
|
||||
index 44fd5a9..eb14462 100644
|
||||
--- a/grub-core/loader/xnu.c
|
||||
+++ b/grub-core/loader/xnu.c
|
||||
@@ -1391,9 +1391,9 @@ grub_xnu_fill_devicetree (void)
|
||||
name[len] = 0;
|
||||
|
||||
curvalue = grub_xnu_create_value (curkey, name);
|
||||
+ grub_free (name);
|
||||
if (!curvalue)
|
||||
return grub_errno;
|
||||
- grub_free (name);
|
||||
|
||||
data = grub_malloc (grub_strlen (var->value) + 1);
|
||||
if (!data)
|
||||
--
|
||||
2.14.2
|
||||
|
||||
Reference in New Issue
Block a user